fix: correct punctuation and grammar in UI warning/tip strings#10813
Conversation
BenJule
force-pushed
the
fix/punctuation-spacing-ui-strings
branch
2 times, most recently
from
1b2215e to
952926e
Compare
Hello, please create a patch to submit. Additionally, the translation files do not need to be changed or submitted, as we have a dedicated translation web management system.
|
Hello, if it's just a spacing issue, don't change it for now. Modifications are allowed if there are grammar or spelling errors.
|
|
Apologies — this PR was closed by mistake on 2026-06-07, and that was an error on my side, not a deliberate decision to withdraw the change. It happened as an unintended side effect of a branch cleanup in my fork: deleting the head branch automatically closed this PR. The contribution still stands. I have restored the branch and reopened the PR. Sorry for the noise and any confusion this caused. |
Adds missing spaces after 'Warning:'/'Error:'/'Tip:' prefixes and fixes grammar in user-facing strings across several GUI source files. Source-string changes only; translation catalogs are left to the upstream gettext pipeline. Closes bambulab#10853
BenJule
force-pushed
the
fix/punctuation-spacing-ui-strings
branch
from
952926e to
ebe38af
Compare
|
Force-pushed: rebased onto current |
BambulabRobot
requested review from
XinZhangBambu and
milk-pure
and removed request for
FiredEgg-bambu,
MackBambu and
milk-pure
|
thanks @BenJule |
3 participants
Summary
Fixes missing spaces after
Warning:,Error:, andTip:prefixes, missing spaces after sentence-ending periods and commas, and several grammar errors in UI strings.Files changed
GLGizmoText.cppWarning:X→Warning: X;create text fail→Text creation failed;text normal is error→Text normal has an error;reedit it will ok→reedit it to fix the issue;dragging text→drag the text; missing comma spacesGLGizmoMeasure.cppWarning:X→Warning: X;two different mesh→two different meshesGLGizmoSVG.cppTip:If...→Tip: If...; missing comma;svg file→SVG filePlaterWorker.hpperror occured→error occurredDeviceManager.cppfilament(PLA...)→filament (PLA...); missing spaces after.and,BindDialog.cppdevice.Before→device. Before;termsand→terms and;Use(collectively)→Use (collectively)ConfigManipulation.cpp,and.in chamber temperature warningAMSSetting.cpp1 minute.The→1 minute. ThePreferences.cpptab.If change value→tab. If you change this valueSource-string changes only — the translation catalogs (
bbl/i18n/*.po,BambuStudio.pot) are left to the upstream gettext pipeline, per maintainer guidance on #10871.Closes #10853.